Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for merging roles #32008

Merged

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jul 12, 2018

This commit adds a test for the most basic function of the CompositeRolesStore which is to merge 2 simple role descriptors into a single role.
There were a lot of tests around FLS/DLS and custom roles providers, but nothing for the most simple case.
This test will be extended to test the merging of conditional (OLS) cluster privileges once they exist on role descriptors.

@tvernum tvernum added >test Issues or PRs that are addressing/adding tests review :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Jul 12, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@jkakavas jkakavas requested review from jkakavas and removed request for albertzaharovits July 16, 2018 04:42
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum tvernum merged commit 154eb1f into elastic:security-app-privs Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants